-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust system mode behavior for Acova (Zehnder) heaters #256
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #256 +/- ##
=======================================
Coverage 96.58% 96.59%
=======================================
Files 61 61
Lines 9526 9550 +24
=======================================
+ Hits 9201 9225 +24
Misses 325 325 ☔ View full report in Codecov by Sentry. |
d09b59f
to
08d6e62
Compare
08d6e62
to
f54d13d
Compare
@@ -589,6 +589,67 @@ class ZenWithinThermostat(Thermostat): | |||
"""Zen Within Thermostat implementation.""" | |||
|
|||
|
|||
@MULTI_MATCH( | |||
cluster_handler_names=CLUSTER_HANDLER_THERMOSTAT, | |||
manufacturers={"ZEHNDER GROUP VAUX ANDIGNY "}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I just tested this branch on my Home Assistant.
Personally, my heater's manufacturer name does not include the trailing spaces. Maybe I have a more recent version, and ZEHNDER has fixed this typo?
I believe both manufacturer names, "ZEHNDER GROUP VAUX ANDIGNY " and "ZEHNDER GROUP VAUX ANDIGNY", exist on the market.
Therefore, I propose a PR to @gdoffe repository to allow support for both manufacturer names. I hope it will be accepted and reflected in this PR :)
Otherwise, I tested it on my side (with this minor change), and it works very well. The modes are correctly mapped thanks to @gdoffe work.
0f11292
to
6b4b750
Compare
Thanks to @mattheop for its review and fixes, it is squashed and pushed. |
@puddly does it seem ok for you ? Just tell me if I need to do other modifications. 🙏 |
6b4b750
to
8c57023
Compare
Anything left to do before this gets merged? |
8c57023
to
6f3d92d
Compare
6c67fe9
to
e978f41
Compare
This commit addresses an issue where SystemMode.AUTO for Acova (Zehnder) heaters behaves differently from the HA standard. For this manufacturer, SystemMode.AUTO allows control of the heater via Zigbee, while SystemMode.HEAT puts the heater in manual mode. As a result, the conversion tables in ZHA climate constants (HVACMode) are incorrect for this device. The mapping for SystemMode.AUTO has been updated to correspond to HVACMode.HEAT instead of HVACMode.HEAT_COOL. Signed-off-by: Gilles DOFFE <g.doffe@gmail.com> Co-authored-by: Matthéo PERELLE <mattheo.perelle@gmail.com>
Signed-off-by: Gilles DOFFE <g.doffe@gmail.com> Co-authored-by: Matthéo PERELLE <mattheo.perelle@gmail.com>
cool, i would like to test this branch in my ha, but same that bterrier, i don't know how i can change ZHA version |
Hi, It's frustrating that this branch hasn't been merged yet, even though it seems to interest many people. Here’s how you can use this branch in your local installation (i am using HA OS but i think you can easily adapt for other instalation type). ⚠ Disclaimer: THIS IS NOT A PERMANENT SOLUTION AND SHOULD ONLY BE USED TEMPORARILY. You will no longer be synced with the latest ZHA versions. Once this branch is merged, you will need to revert the following changes. You will need to override the ZHA core component. I will try my best to help you with following instructions Steps
If everything is set up correctly, your previously buggy thermostat widget should now function properly and match the latest changes shared by @gdoffe. Let me know if you encounter any issues. FYI: @bterrier @guillerelax edit: sorry for previous deleted post, i miss some instructions |
This PR addresses an issue where SystemMode.AUTO for Acova (Zehnder) heaters behaves differently from the HA standard. For this manufacturer, SystemMode.AUTO allows control of the heater via Zigbee, while SystemMode.HEAT puts the heater in manual mode.
As a result, the conversion tables in ZHA climate constants (HVACMode) are incorrect for this device. The mapping for SystemMode.AUTO has been updated to correspond to HVACMode.HEAT instead of HVACMode.HEAT_COOL.
See zigpy/zha-device-handlers#2921